I do not normally post to FOPNU but I have a simple Windows how - to which could be found on search.  I put my folder of the screen shots in the library and then searched for my own library folder.  I did not see it found in search.  What am I doing wrong?

First, can you see your own files at all? If your ISP hasn't configured NAT for hairpinning (connections from public user port to itself), you might not.

Copy your user link. Open your user link. Do you see your shared files, or it's “user offline” after some time?

If Fopnu works fine, other users should be able to connect to you even if you can't in that specific network configuration.

Second, sharing and searching is based on file type categories. In context menu for all shared directories, there's a file type sub-menu. If you want to share all files, you need to check all types. If you want to search for all files, you need to check all types

I guess it protects novice users from themselves in case they share system files or make similar mistakes, but you need to set all the check boxes when adding shares at least once.

Yes ok, I'll check the file type.  I'm on the donors list as well.  Thanks for providing filesharing tools

 I unchecked Audio and Video and checked in Images and Text for the small series of help notes I have made
based on some Git Hub info for a software.

I’ve run into a similar issue when trying to organize screenshots and share them across local tools. Even when the files were technically shared, the indexing or file type options messed things up, and they wouldn’t show in search results. Making sure image files are marked properly and the folder is categorized under the right type definitely helped. It's one of those small but easy-to-miss steps.